Skip to content

Fix overriding default_args in nested task groups - #31608

Merged
hussein-awala merged 3 commits into
apache:mainfrom
hussein-awala:fix/nested_tg_default_agrs
May 30, 2023
Merged

hussein-awala merged 3 commits into
apache:mainfrom
hussein-awala:fix/nested_tg_default_agrs

Conversation

@hussein-awala

Copy link
Copy Markdown
Member

closes: #31604


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Signed-off-by: Hussein Awala <hussein@awala.fr>
Signed-off-by: Hussein Awala <hussein@awala.fr>
@hussein-awala hussein-awala added type:bug-fix Changelog: Bug Fixes area:core labels May 30, 2023
@hussein-awala hussein-awala added this to the Airflow 2.6.2 milestone May 30, 2023
Comment thread airflow/utils/task_group.py Outdated
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
@uranusjr uranusjr changed the title Fix overriding default_agrs in nested task groups Fix overriding default_args in nested task groups May 30, 2023
@hussein-awala
hussein-awala merged commit 9e8627f into apache:main May 30, 2023
Comment thread airflow/utils/task_group.py
eladkal pushed a commit that referenced this pull request Jun 8, 2023
* add unit tests for default_args overriding in task group

Signed-off-by: Hussein Awala <hussein@awala.fr>

* fix overriding default args in nested task groups

Signed-off-by: Hussein Awala <hussein@awala.fr>

* Update airflow/utils/task_group.py

Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>

---------

Signed-off-by: Hussein Awala <hussein@awala.fr>
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
(cherry picked from commit 9e8627f)
@eladkal eladkal mentioned this pull request Jun 13, 2023
40 of 62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Override default_args between Nested TaskGroups

4 participants