Repository navigation
Consolidate import and usage of itertools - #33479
Merged
Merged
Conversation
eumiro
requested review from
XD-DENG,
ashb,
bbovenzi,
eladkal,
jedcunningham,
kaxil,
o-nikolas,
pierrejeambrun,
potiuk,
ryanahamilton and
uranusjr
as code owners
August 17, 2023 17:19
boring-cyborg
Bot
added
area:CLI
area:dev-tools
area:lineage
area:providers
area:scheduler
area:webserver
Member
|
If we want to consolidate (not strictly necessary) I’d prefer the full |
kaxil
reviewed
Aug 18, 2023
eumiro
force-pushed
the
itertools
branch
3 times, most recently
from
August 19, 2023 17:40
b928305 to
c94feea
Compare
uranusjr
reviewed
Aug 20, 2023
Member
There was a problem hiding this comment.
This can just be
Suggested change
| self.inlets.extend(itertools.chain.from_iterable(_inlets)) | |
| self.inlets.extend(i for it in _inlets for i in it) |
but itertools has readability advantages.
uranusjr
reviewed
Aug 20, 2023
Contributor
Author
There was a problem hiding this comment.
In the subsequent line:
if argument is None or default is None:
continueall the lines that come from zip_longest but are ignored in zip are ignored anyway.
eumiro
force-pushed
the
itertools
branch
2 times, most recently
from
August 20, 2023 05:25
524bb1c to
1f89278
Compare
Member
|
Conflicts :( |
uranusjr
approved these changes
Aug 21, 2023
potiuk
approved these changes
Aug 21, 2023
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
(cherry picked from commit 95a930b)
46 of 97 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.