Skip to content

k8s spark operator compatibility - #36268

Closed
blcksrx wants to merge 1 commit into
apache:mainfrom
blcksrx:spark_k8s_operator
Closed

blcksrx wants to merge 1 commit into
apache:mainfrom
blcksrx:spark_k8s_operator

Conversation

@blcksrx

@blcksrx blcksrx commented Dec 17, 2023 •

Copy link
Copy Markdown
Contributor

Changes in this PR:

  • Added override_existing argument with default to the operator.
  • Uses the K8S application uid instead of naming

closes: #32363


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Dec 17, 2023
Comment thread airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py Outdated
@assaf-xm

Copy link
Copy Markdown

@blcksrx is there any progress with the review of this PR?
(this is a small PR)

@blcksrx

blcksrx commented Jan 23, 2024

Copy link
Copy Markdown
Contributor Author

@assaf-xm no review yet :(

@ruslanguns

Copy link
Copy Markdown

This PR is very important for us, we are start working with Airflow and Spark and this additional means a lot. I really encourage the reviewers to review this. Thanks in advanced:

FYI @jedcunningham @hussein-awala @josh-fell

@potiuk

potiuk commented Jan 24, 2024

Copy link
Copy Markdown
Member

Can you rebase it please @blcksrx ? There are some conflicts.

@blcksrx

blcksrx commented Jan 25, 2024 •

Copy link
Copy Markdown
Contributor Author

@potiuk I see a lot of changes, It gonna check it during the weekend

@romsharon98

romsharon98 commented Feb 4, 2024 •

Copy link
Copy Markdown
Contributor

I think it will be nice to add override_existing as templated field.
If it's not to much can u add it?

@blcksrx

blcksrx commented Feb 4, 2024

Copy link
Copy Markdown
Contributor Author

A major change happened in the operator actually, that makes it hard to do it!
The new change generates a new job name(at least what i understood from the code) and it needs collaboration of these changes commiters

@romsharon98

Copy link
Copy Markdown
Contributor

A major change happened in the operator actually, that makes it hard to do it! The new change generates a new job name(at least what i understood from the code) and it needs collaboration of these changes commiters

isn't it just to add this line:

    template_fields: Sequence[str] = ("application_file", "namespace", "override_existing")

or I missing something?

@blcksrx

blcksrx commented Feb 4, 2024

Copy link
Copy Markdown
Contributor Author

This part is simple,the operator it self got completely changed, check it from the main branch

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 21, 2024
@github-actions github-actions Bot closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

K8S Spark Operator doesn't delete an older application with the same name anymore

6 participants