Skip to content

Fixing template_fields for WeaviateIngestOperator #36359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Dec 21, 2023
Merged

Fixing template_fields for WeaviateIngestOperator #36359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f87f94
fixing teamplate fields for WeaviateIngestOperator
vatsrahul1001 Dec 21, 2023
fb957d0
removing fxitures which are not required
vatsrahul1001 Dec 21, 2023
0174288
marking test as db as its accessing db
vatsrahul1001 Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow/providers/weaviate/operators/weaviate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class WeaviateIngestOperator(BaseOperator):
:param vector_col: key/column name in which the vectors are stored.
"""

template_fields: Sequence[str] = ("input_json",)
template_fields: Sequence[str] = ("input_json", "input_data")

def __init__(
self,
Expand All @@ -69,7 +69,7 @@ def __init__(
self.class_name = class_name
self.conn_id = conn_id
self.vector_col = vector_col

self.input_json = input_json
if input_data is not None:
self.input_data = input_data
elif input_json is not None:
Expand Down
17 changes: 17 additions & 0 deletions tests/providers/weaviate/operators/test_weaviate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,20 @@ def test_execute_with_input_json(self, mock_log, operator):
"my_class", {"data": "sample_data"}, vector_col="Vector", **{}
)
mock_log.debug.assert_called_once_with("Input data: %s", {"data": "sample_data"})

@pytest.mark.db_test
def test_templates(self, create_task_instance_of_operator):
dag_id = "TestWeaviateIngestOperator"
ti = create_task_instance_of_operator(
WeaviateIngestOperator,
dag_id=dag_id,
task_id="task-id",
conn_id="weaviate_conn",
class_name="my_class",
input_json="{{ dag.dag_id }}",
input_data="{{ dag.dag_id }}",
)
ti.render_templates()

assert dag_id == ti.task.input_json
assert dag_id == ti.task.input_data