Repository navigation
prevent celery command autoscale misconfig - #36576
Merged
Merged
Conversation
dirrao
requested changes
Jan 4, 2024
dirrao
left a comment
dirrao
left a comment
Contributor
There was a problem hiding this comment.
Static checks are failing. I would request you to use pre commit hooks or breeze CLI static checks.
https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#:~:text=available%20bash%20scripts.-,Pre%2Dcommit%20hooks,on%20and%20make%20them%20fast.
Bowrna
force-pushed
the
celery-autoscale-misconfig-issue
branch
3 times, most recently
from
January 4, 2024 09:32
8401312 to
42709e2
Compare
dirrao
requested changes
Jan 5, 2024
dirrao
left a comment
dirrao
left a comment
Contributor
There was a problem hiding this comment.
Existing test cases are failing. Can you update the existing ones and add the new test case?
Contributor
Author
|
hi @dirrao yes the static checks are expected to fail. I will need response for this comment #35332 (comment) to proceed further with this. |
Bowrna
force-pushed
the
celery-autoscale-misconfig-issue
branch
2 times, most recently
from
January 28, 2024 15:25
b5bc45b to
f281155
Compare
Bowrna
force-pushed
the
celery-autoscale-misconfig-issue
branch
from
January 28, 2024 15:55
f281155 to
0882e7f
Compare
Bowrna
marked this pull request as ready for review
January 28, 2024 17:35
Contributor
Author
|
i have fixed some parts in documentation alone here in this PR. The actual issue is not an issue and therefore I just enhanced the docs alone |
potiuk
approved these changes
Jan 28, 2024
57 of 81 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #35332
related: #35332
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.