feat: update SnowflakeSqlApiHook to support OAuth - #37922
Merged
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
andyguwc
force-pushed
the
tianyou/snowflake-sql-api
branch
from
March 5, 2024 23:50
0d14c7e to
a56a573
Compare
andyguwc
force-pushed
the
tianyou/snowflake-sql-api
branch
from
March 6, 2024 01:59
a56a573 to
35fb2d0
Compare
potiuk
approved these changes
Mar 6, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
1 of 2 tasks
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates SnowflakeSqlApiHook to support OAuth.
In order to update this hook have to update the
SnowflakeHookto parse the refresh token and client credentials.The OAuth workflow assumes the user already obtained the
refresh_token,client_id, andclient_secret. In particular therefresh_tokenshould be obtained outside of airflow.The PR also fixes the snowflake
account_identifierused in the hook which used to force a region, but region should be optional in the identifier.Also tested locally by running the
SnowflakeSqlApiOperatoroperator in example DAG.closes: #36621
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.