Repository navigation
ECS Executor retry task bug fix - #37979
Merged
eladkal merged 1 commit intoMar 9, 2024
Merged
Conversation
…ailed. Add unit tests to catch case where tasks fail
boring-cyborg
Bot
added
area:providers
provider:amazon
o-nikolas
approved these changes
Mar 7, 2024
dirrao
approved these changes
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug in the ECS Executor where the executor did not attempt all queued tasks in one
synccycle if a task failed. This PR fixes the behaviour, and the ECS Executor now attempts all queued tasks exactly once per iteration, regardless of the state of the task. If a task fails to run (i.e. someExceptionis thrown when callingrun_task), it gets put back on the queued tasks list, and gets attempted in the nextsynciteration. This continues until the maximum number of attempts for a task has been reached.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.