Repository navigation
Fix cursor unique name surpasses Postgres identifier limit in PostgresToGCSOperator - #38040
Merged
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
potiuk
approved these changes
Mar 11, 2024
PostgresToGCSOperator
eladkal
reviewed
Mar 11, 2024
Taragolis
reviewed
Mar 11, 2024
dybolo
force-pushed
the
postgres_to_gcs_unique_name
branch
2 times, most recently
from
March 16, 2024 21:57
affa9e4 to
9d98548
Compare
potiuk
approved these changes
Mar 19, 2024
…es identifier limit function unique_name generates UUID from the SHA-1 hash using the dag id and the task id. The previous version of the function throwed unterminated quoted identifier error when the operator was used with a task_id greater than 24 bytes as the name generated surpassed the postgres identifier limit.
… to non-deterministic and utilized slugify to ensure compliance with length limits
potiuk
force-pushed
the
postgres_to_gcs_unique_name
branch
from
March 19, 2024 14:43
9d98548 to
7864135
Compare
Member
Taragolis
approved these changes
Mar 19, 2024
eladkal
approved these changes
Mar 19, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #37654
The function unique_name now generates UUID from the SHA-1 hash using the dag id and the task id. The previous version of the function throwed unterminated quoted identifier error when the operator was used with a task_id greater than 24 bytes as the name generated surpassed the postgres identifier limit.