Rename MLEngine operators' fields' names to comply with templated fields validation - #38053
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:dev-tools
area:providers
provider:google
dirrao
requested changes
Mar 12, 2024
shahar1
marked this pull request as draft
March 12, 2024 22:14
shahar1
force-pushed
the
rename-mlengine-fields
branch
from
March 15, 2024 07:57
666384d to
54b52cb
Compare
shahar1
marked this pull request as ready for review
March 15, 2024 07:57
Contributor
Author
As all renamed attributes were private, there shouldn't be a risk of backward incompatibility. |
Contributor
Author
|
Done |
shahar1
force-pushed
the
rename-mlengine-fields
branch
from
March 15, 2024 12:12
54b52cb to
4034a14
Compare
shahar1
changed the title
MLEngine operators' fields' names to comply with templated fields validation
Contributor
|
Mypy test is failing |
shahar1
force-pushed
the
rename-mlengine-fields
branch
from
March 15, 2024 13:09
4034a14 to
fe73830
Compare
Contributor
Author
Should be ok now |
eladkal
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #36484
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.