Use startup_check_interval_seconds instead of poll_interval to check pod while startup - #38075
Merged
pankajastro merged 3 commits intoMar 18, 2024
Merged
Conversation
…pod while startup
pankajastro
requested review from
hussein-awala and
jedcunningham
as code owners
March 12, 2024 13:42
boring-cyborg
Bot
added
area:providers
provider:cncf-kubernetes
1 of 2 tasks
dirrao
reviewed
Mar 12, 2024
pankajkoti
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the KPO trigger utilizes the polling_interval parameter to
check the status of a pod during its startup. However,
this approach appears incorrect and inconsistent with
the synchronous version of the operator, where we use the
startup_check_interval_seconds. The asynchronous approach should
also use the startup_check_interval_seconds parameter to check the
status of a pod during its startup.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.