Skip to content

Update SqlToSlackApiFileOperator with new param to check empty output - #38079

Merged
Taragolis merged 4 commits into
apache:mainfrom
andyguwc:tianyou/slack-file-operator
Mar 18, 2024
Merged

Taragolis merged 4 commits into
apache:mainfrom
andyguwc:tianyou/slack-file-operator

Conversation

@andyguwc

@andyguwc andyguwc commented Mar 12, 2024 •

Copy link
Copy Markdown
Contributor

This PR adds a new param to the SqlToSlackApiFileOperator to optionally allow skipping sending an empty file.

closes: #37191


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Comment thread airflow/providers/slack/transfers/sql_to_slack.py Outdated
Comment thread airflow/providers/slack/transfers/sql_to_slack.py Outdated
Comment thread airflow/providers/slack/transfers/sql_to_slack.py Outdated
@andyguwc
andyguwc force-pushed the tianyou/slack-file-operator branch from a29bdf6 to 012fc39 Compare March 12, 2024 18:37
Comment thread airflow/providers/slack/transfers/sql_to_slack.py Outdated
Comment thread tests/providers/slack/transfers/test_sql_to_slack.py Outdated
Comment thread tests/providers/slack/transfers/test_sql_to_slack.py Outdated
Comment thread tests/providers/slack/transfers/test_sql_to_slack.py Outdated
Comment thread airflow/providers/slack/transfers/sql_to_slack.py Outdated
Comment thread airflow/providers/slack/transfers/sql_to_slack.py Outdated
@andyguwc
andyguwc force-pushed the tianyou/slack-file-operator branch 2 times, most recently from 1f5ea1f to c49f8e0 Compare March 15, 2024 16:12
@andyguwc
andyguwc requested a review from Taragolis March 15, 2024 16:33
@eladkal eladkal changed the title fix: Update SqlToSlackApiFileOperator with new param to check empty output Update SqlToSlackApiFileOperator with new param to check empty output Mar 16, 2024

@eladkal eladkal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyguwc
andyguwc force-pushed the tianyou/slack-file-operator branch from c49f8e0 to 1d4d180 Compare March 18, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SqlToSlackApiFileOperator - Empty files

4 participants