Skip to content

ECSExecutor API Retry bug fix - #38118

Merged
o-nikolas merged 3 commits into
apache:mainfrom
aws-mwaa:syedahsn/aws_executors_ecs_bug_api_retry_fix
Mar 18, 2024
Merged

o-nikolas merged 3 commits into
apache:mainfrom
aws-mwaa:syedahsn/aws_executors_ecs_bug_api_retry_fix

Conversation

@syedahsn

Copy link
Copy Markdown
Contributor

There was a bug in the ECS Executor which prevented the Executor from retrying tasks on API failures. This fixes the bug. This PR also addresses how REMOVED tasks are handled. We now treat tasks marked as REMOVED the same way we handle FAILED tasks. Unit tests have been updated to follow the new logic.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Mar 13, 2024
Comment thread airflow/providers/amazon/aws/executors/ecs/ecs_executor.py
Comment thread airflow/providers/amazon/aws/executors/ecs/ecs_executor.py
Comment thread tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py
@eladkal eladkal changed the title ECS API Retry bug fix ECSExecutor API Retry bug fix Mar 14, 2024
@o-nikolas
o-nikolas merged commit 111245a into apache:main Mar 18, 2024
@o-nikolas
o-nikolas deleted the syedahsn/aws_executors_ecs_bug_api_retry_fix branch March 18, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants