Skip to content

fix cosmos hook static checks by making providing partition_key mandatory - #38199

Merged
hussein-awala merged 7 commits into
apache:mainfrom
hussein-awala:fix/cosmos_typing
Apr 10, 2024
Merged

hussein-awala merged 7 commits into
apache:mainfrom
hussein-awala:fix/cosmos_typing

Conversation

@hussein-awala

@hussein-awala hussein-awala commented Mar 16, 2024 •

Copy link
Copy Markdown
Member

closes: #38196

According to Azure/azure-sdk-for-python#34795 (comment) we cannot create non-partitioned cosmos collections anymore, this is badly handled in the Python SDK but we will receive an API exception if we try to do that.

I update the PR to make the partition_key mandatory, with the possibility to define a default one in the connection.

@potiuk

potiuk commented Mar 16, 2024

Copy link
Copy Markdown
Member

Nice :). Airflow detecting and spreading fixes to hundreds of libraries :)

@dirrao dirrao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmos related test cases are failing.

@hussein-awala

Copy link
Copy Markdown
Member Author

Cosmos related test cases are failing.

Check the PR description, it depends on another PR that fixes the issue in the microsoft sdk.

@hussein-awala hussein-awala changed the title Remove cosmos upper bound version and fix type annotations fix cosmos hook static checks by making providing partition_key mandatory Apr 1, 2024
@hussein-awala

Copy link
Copy Markdown
Member Author

@eladkal I updated the PR and its description according to azure python SDK maintainers, could you check if we can consider it as a bug fix or if we need a new major release? Do I need to add something to changelog?

@eladkal
eladkal self-requested a review April 1, 2024 17:49
@eladkal

eladkal commented Apr 4, 2024 •

Copy link
Copy Markdown
Contributor

@eladkal I updated the PR and its description according to azure python SDK maintainers, could you check if we can consider it as a bug fix or if we need a new major release? Do I need to add something to changelog?

I don't think it qualify as breaking but the next release is major due to another PR so we can treat this one as major change in terms of the entry log.

Simply add the needed explnation for users on the 1.10 entry of the change log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve mypy violations for azure-cosmos >= 4.6.0

4 participants