fix cosmos hook static checks by making providing partition_key mandatory - #38199
Conversation
|
Nice :). Airflow detecting and spreading fixes to hundreds of libraries :) |
dirrao
left a comment
There was a problem hiding this comment.
Cosmos related test cases are failing.
Check the PR description, it depends on another PR that fixes the issue in the microsoft sdk. |
|
@eladkal I updated the PR and its description according to azure python SDK maintainers, could you check if we can consider it as a bug fix or if we need a new major release? Do I need to add something to changelog? |
I don't think it qualify as breaking but the next release is major due to another PR so we can treat this one as major change in terms of the entry log. Simply add the needed explnation for users on the 1.10 entry of the change log |
closes: #38196
According to Azure/azure-sdk-for-python#34795 (comment) we cannot create non-partitioned cosmos collections anymore, this is badly handled in the Python SDK but we will receive an API exception if we try to do that.
I update the PR to make the
partition_keymandatory, with the possibility to define a default one in the connection.