Repository navigation
Support multiple Docker hosts in docker_url attribute. - #38466
Merged
Merged
Conversation
Taragolis
reviewed
Mar 25, 2024
Taragolis
left a comment
Taragolis
left a comment
Contributor
There was a problem hiding this comment.
Also need to fix static checks and add some tests for this feature
Contributor
Author
|
@Taragolis Thank you for the detailed review. 👍 |
Taragolis
reviewed
Mar 26, 2024
oboki
force-pushed
the
feature-for-multi-host-connection
branch
2 times, most recently
from
March 26, 2024 16:05
5f187ed to
ba1227f
Compare
Taragolis
reviewed
Mar 28, 2024
Taragolis
left a comment
Taragolis
left a comment
Contributor
There was a problem hiding this comment.
Also need to add new tests cases for hook, and update docstrings
oboki
force-pushed
the
feature-for-multi-host-connection
branch
2 times, most recently
from
March 29, 2024 19:46
271d0d6 to
f225232
Compare
* Allowing `docker_url` in `DockerOperator` and `base_url` in `DockerHook` to accept a list of str. * Iterating over multiple host URLs to create and attempt connection.
oboki
force-pushed
the
feature-for-multi-host-connection
branch
from
March 29, 2024 20:00
f225232 to
12ec5bc
Compare
Taragolis
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves
DockerOperatorto support multiple Docker hosts, enabling high availability.Changes include:
docker_urlparameter to accept a list of str.