Skip to content

Fix skip Apache Beam pipeline options if value is set to false #38496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Apr 7, 2024
Merged

Fix skip Apache Beam pipeline options if value is set to false #38496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions airflow/providers/apache/beam/hooks/beam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ def beam_options_to_args(options: dict) -> list[str]:
for attr, value in options.items():
if value is None or (isinstance(value, bool) and value):
args.append(f"--{attr}")
elif isinstance(value, bool) and not value:
continue
elif isinstance(value, list):
args.extend([f"--{attr}={v}" for v in value])
else:
Expand Down
2 changes: 1 addition & 1 deletion tests/providers/apache/beam/hooks/test_beam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ class TestBeamOptionsToArgs:
({"key": "val"}, ["--key=val"]),
({"key": None}, ["--key"]),
({"key": True}, ["--key"]),
({"key": False}, ["--key=False"]),
({"key": False}, []),
({"key": ["a", "b", "c"]}, ["--key=a", "--key=b", "--key=c"]),
],
)
Expand Down