Repository navigation
Add fallback region_name value to AWS Executors - #38704
Merged
Merged
Conversation
Taragolis
force-pushed
the
aws-executors-fallback-region
branch
from
April 3, 2024 12:01
40ec80c to
43d616e
Compare
potiuk
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fallback to
region_nameit might not obtained if configuration not persists inairflow.cfgor in env vars or configuration loaded without provider configurationsIn addition use
conf_varshelper for configure tests, it will automatically undo configuration in the end of test, so it reduce side effect when one test allow to pass/fail next text tests.Originally it cause flakey behaviour in parallel non-db tests when it might run tests agains not properly configured tests in
mainor PRs^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.