Skip to content

Fix TRY002 for apache hive provider - #38781

Merged
potiuk merged 2 commits into
apache:mainfrom
amoghrajesh:fixGeneralExceptionHIve
Apr 5, 2024
Merged

potiuk merged 2 commits into
apache:mainfrom
amoghrajesh:fixGeneralExceptionHIve

Conversation

@amoghrajesh

@amoghrajesh amoghrajesh commented Apr 5, 2024 •

Copy link
Copy Markdown
Contributor

While fixing some code in the hive hook, realised that it raises general exceptions. Instead, it can be specific, in this case, ValueError.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@amoghrajesh

Copy link
Copy Markdown
Contributor Author

Oh interesting, came across this task: #38761
Let me add the changes per that issue

@amoghrajesh amoghrajesh changed the title Mark general exception as ValueError instead Fix TRY002 for apache hive provider Apr 5, 2024
@amoghrajesh
amoghrajesh requested a review from Taragolis April 5, 2024 15:51
@potiuk
potiuk merged commit cec6d31 into apache:main Apr 5, 2024
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:apache-hive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants