Repository navigation
Close open connections for deferrable SFTPSensor - #38881
Merged
phanikumv merged 3 commits intoApr 10, 2024
Merged
Conversation
pankajkoti
force-pushed
the
close-ssh-connection-deferrable-sftp
branch
from
April 9, 2024 19:50
6e39800 to
662d61b
Compare
Member
Author
hussein-awala
left a comment
Member
There was a problem hiding this comment.
The change looks good, I think it is possible to test it by checking if the method __aexit__ (or close if it has one) is called.
However, I wonder why you need # type: ignore[return]? 🤔
Lee-W
force-pushed
the
close-ssh-connection-deferrable-sftp
branch
from
April 10, 2024 02:10
5c0bd70 to
119fd3b
Compare
Member
Yep, this is what we should check and is part of the reason why the tests failed originally. Just fixed it 🔧
Otherwise, we'll encounter |
Lee-W
marked this pull request as ready for review
April 10, 2024 02:56
Member
|
I also test it locally to verify the functionality. 👍 |
phanikumv
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




It's observed that running the SFTPSensor in deferrable mode
fails to close opened SSH connections to the server, resulting
in a continuous increase of open connections over time.
This pull request addresses this issue by ensuring that
connections are opened using a context manager, allowing
them to be closed once the relevant data has been read
from the SSH server during file sensing.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.