Repository navigation
Conversation
danielbe11
marked this pull request as draft
April 16, 2024 16:05
danielbe11
marked this pull request as ready for review
April 17, 2024 15:19
dirrao
requested changes
Apr 18, 2024
dirrao
left a comment
dirrao
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Can you add the test with verify is set to True?
…thub.com:danielbe11/airflow into druid-operator-pass-ssl-arg-to-all-request-calls
Contributor
Author
|
Thanks for the review @dirrao, added the other test |
danielbe11
force-pushed
the
druid-operator-pass-ssl-arg-to-all-request-calls
branch
from
April 18, 2024 10:11
c181728 to
0172704
Compare
danielbe11
marked this pull request as draft
April 19, 2024 08:07
danielbe11
marked this pull request as ready for review
April 20, 2024 17:12
danielbe11
commented
Apr 25, 2024
eladkal
approved these changes
May 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verifykwarg in the first post request (the one assigningreq_indexvar). We should be passing the arg to all the requests in the operator.requestsets this True by default ref^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.