Skip to content

Switch committer builds to public runners #39106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Apr 18, 2024
Merged

Switch committer builds to public runners #39106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions dev/breeze/src/airflow_breeze/utils/selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,10 +1090,7 @@ def runs_on_as_json_default(self) -> str:
if USE_SELF_HOSTED_RUNNERS_LABEL in self._pr_labels:
# Forced self-hosted runners
return RUNS_ON_SELF_HOSTED_RUNNER
if actor in COMMITTERS:
return RUNS_ON_SELF_HOSTED_RUNNER
else:
return RUNS_ON_PUBLIC_RUNNER
return RUNS_ON_PUBLIC_RUNNER
return RUNS_ON_PUBLIC_RUNNER

@cached_property
Expand Down
20 changes: 10 additions & 10 deletions dev/breeze/tests/test_selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1700,13 +1700,13 @@ def test_helm_tests_trigger_ci_build(files: tuple[str, ...], expected_outputs: d
"apache/airflow",
(),
dict(),
'["self-hosted", "Linux", "X64"]',
"true",
"true",
"true",
'["ubuntu-22.04"]',
"false",
"false",
"true",
"false",
"false",
"false",
False,
id="Pull request committer",
),
Expand Down Expand Up @@ -1780,13 +1780,13 @@ def test_helm_tests_trigger_ci_build(files: tuple[str, ...], expected_outputs: d
"apache/airflow",
[],
dict(),
'["self-hosted", "Linux", "X64"]',
"true",
"true",
"true",
'["ubuntu-22.04"]',
"false",
"false",
"true",
"false",
"false",
"false",
False,
id="Pull request target committer",
),
Expand Down Expand Up @@ -2065,7 +2065,7 @@ def test_mypy_matches(
("README.md",),
{
"is-committer-build": "true",
"runs-on-as-json-default": '["self-hosted", "Linux", "X64"]',
"runs-on-as-json-default": '["ubuntu-22.04"]',
},
"potiuk",
(),
Expand All @@ -2075,7 +2075,7 @@ def test_mypy_matches(
("README.md",),
{
"is-committer-build": "false",
"runs-on-as-json-default": '["self-hosted", "Linux", "X64"]',
"runs-on-as-json-default": '["ubuntu-22.04"]',
},
"potiuk",
("non committer build",),
Expand Down