Repository navigation
Refactor SafeDogStatsdLogger to use get_validator to enable pattern matching - #39370
Conversation
SafeDogStatsdLoggerSafeDogStatsdLogger to use get_validator to get validators
SafeDogStatsdLogger to use get_validator to get validatorsSafeDogStatsdLogger to use get_validator to get validators
SafeDogStatsdLogger to use get_validator to get validatorsSafeDogStatsdLogger to use get_validator to enable pattern matching
pankajkoti
left a comment
There was a problem hiding this comment.
were you able to test this end to end with Datadog using all the 3 configurations? Allow list, block list and pattern list? Also could you please add tests for all those configurations if they don't exist already?
|
@pankajkoti, Yes, I have tested them. Allow/Block list without pattern worked perfectly. However, I noticed the following behaviour when using pattern matching, which I am not sure if it's right. With pattern matching enabled:
In the 2nd screenshot, I still see several metrics that don't have |
|
Env variables set:
|
ferruzzi
left a comment
There was a problem hiding this comment.
Code change LGTM, but I'm not sure that second allow-list example (the one you seemed unsure about) is working as expected. Either way, that is not in scope for this PR if that is broken, but you may want to look into that more if you have the time.
I will look into it. I will create an issue( #39400) and post my findings there. |
…rn matching (apache#39370) closes apache#39368 By reusing the get_validators function, we can incorporate pattern search to include allow/block lists.



closes #39368
By reusing the
get_validatorsfunction, we can incorporate pattern search to include allow/block lists.