Repository navigation
misc: add comment about remove unused code - #39748
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:amazon
hussein-awala
approved these changes
May 22, 2024
pankajkoti
reviewed
May 22, 2024
pankajkoti
left a comment
pankajkoti
left a comment
Member
There was a problem hiding this comment.
I see in other places that we add a TODO marker for code that needs to be removed later. Might help to also search for these with the TODO marker.
Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
* misc: add comment about remove unused code * Update airflow/providers/amazon/aws/executors/ecs/ecs_executor.py Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> * Update airflow/providers/celery/executors/celery_executor.py Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com> --------- Co-authored-by: Pankaj Koti <pankajkoti699@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#39212 is planned for 2.9.2 so adding a note when we need to remove the unused code.