Repository navigation
Fix mocking in kerberos integration test - #40042
Merged
Merged
Conversation
The new requests-kerberos has a slightly different approach for parsing urls and extracting hostname from url causes a problem with "mock cannot be compared to int" when mock is returned as URL. This PR fixes it by hard-coding returned URL in the mock that is being returned in this case.
hussein-awala
approved these changes
Jun 4, 2024
ephraimbuddy
pushed a commit
that referenced
this pull request
Jun 5, 2024
The new requests-kerberos has a slightly different approach for parsing urls and extracting hostname from url causes a problem with "mock cannot be compared to int" when mock is returned as URL. This PR fixes it by hard-coding returned URL in the mock that is being returned in this case. (cherry picked from commit 32fd29d)
13 of 41 tasks
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
The new requests-kerberos has a slightly different approach for parsing urls and extracting hostname from url causes a problem with "mock cannot be compared to int" when mock is returned as URL. This PR fixes it by hard-coding returned URL in the mock that is being returned in this case.
syedahsn
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 7, 2024
The new requests-kerberos has a slightly different approach for parsing urls and extracting hostname from url causes a problem with "mock cannot be compared to int" when mock is returned as URL. This PR fixes it by hard-coding returned URL in the mock that is being returned in this case.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
The new requests-kerberos has a slightly different approach for parsing urls and extracting hostname from url causes a problem with "mock cannot be compared to int" when mock is returned as URL. This PR fixes it by hard-coding returned URL in the mock that is being returned in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new requests-kerberos has a slightly different approach for parsing urls and extracting hostname from url causes a problem with "mock cannot be compared to int" when mock is returned as URL.
This PR fixes it by hard-coding returned URL in the mock that is being returned in this case.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.