Skip to content

catch sentry flush if exception happens in _execute_in_fork finally block - #40060

Merged
eladkal merged 2 commits into
apache:mainfrom
astronomer:improve-execute-in-fork-finally-block-handling
Jun 7, 2024
Merged

eladkal merged 2 commits into
apache:mainfrom
astronomer:improve-execute-in-fork-finally-block-handling

Conversation

@Lee-W

@Lee-W Lee-W commented Jun 5, 2024

Copy link
Copy Markdown
Member

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W
Lee-W requested a review from hussein-awala as a code owner June 5, 2024 08:58
@Lee-W Lee-W changed the title catch sentry flush exception in _execute_in_fork catch sentry flush if exception happens in _execute_in_fork finally block Jun 5, 2024
Comment thread airflow/providers/celery/executors/celery_executor_utils.py Outdated
@Lee-W
Lee-W force-pushed the improve-execute-in-fork-finally-block-handling branch from 3e00f02 to 5f8998f Compare June 6, 2024 01:47
@eladkal
eladkal merged commit 80522b9 into apache:main Jun 7, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…lock (apache#40060)

* feat(providers/celery): catch sentry flush exception in _execute_in_fork

* feat(providers/celery): add logging.shutdown into finally block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants