Revert "Fix: DAGs are not marked as stale if the dags folder change (#41433) - #41852
Closed
ephraimbuddy wants to merge 1 commit into
Closed
ephraimbuddy wants to merge 1 commit into
ephraimbuddy wants to merge 1 commit into
Conversation
…pache#41433)" This reverts commit 9f30a41.
ephraimbuddy
force-pushed
the
revert-41433
branch
from
August 29, 2024 09:42
8953f8b to
60c2fa2
Compare
Lee-W
approved these changes
Aug 29, 2024
Member
|
@ephraimbuddy do we need to create one for v2-10-test as well |
Contributor
Author
Hmm. Let's wait before merging this. Looks like @utkarsharma2 has a solution. If that doesn't work, we will have to revert the one in v2-10-test |
Contributor
|
@ephraimbuddy, @Lee-W PTAL - #41856 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 9f30a41.
This PR is causing constant deletion of serialized DAG even when the dag folder did not change.
cc @utkarsharma2