Repository navigation
AIP-84 Migrate the public endpoint DAG Details to FastAPI - #42631
Merged
Merged
Conversation
omkar-foss
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
October 1, 2024 20:14
omkar-foss
requested review from
bbovenzi,
jscheffl and
ryanahamilton
as code owners
October 1, 2024 21:13
omkar-foss
force-pushed
the
aip-84/dags/get-dag-details
branch
from
October 1, 2024 21:15
7ab0093 to
5e5fabc
Compare
1 task done
pierrejeambrun
changed the title
omkar-foss
force-pushed
the
aip-84/dags/get-dag-details
branch
from
October 2, 2024 21:07
5250a48 to
79ea68d
Compare
Collaborator
Author
Thank you for the review! I've updated the PR as per your comments. All checks have passed and PR is ready for (re-)review. |
bbovenzi
approved these changes
Oct 3, 2024
bbovenzi
left a comment
bbovenzi
left a comment
Contributor
There was a problem hiding this comment.
The final UI types look good to me
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* Migrate the public endpoint DAG Details to FastAPI * Add comment for computed_field, remove unused import * Update pendulum import path * Re-run breeze static checks * Add openapi-gen for DAG Details API * Resolve review comments, test has_task_concurrency_limits * Remove unused import * Use lambda for aliases, re-run breeze static checks * Remove duplicate entry * Use simpler approach for alias
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Migrate the public endpoint DAG Details to FastAPI * Add comment for computed_field, remove unused import * Update pendulum import path * Re-run breeze static checks * Add openapi-gen for DAG Details API * Resolve review comments, test has_task_concurrency_limits * Remove unused import * Use lambda for aliases, re-run breeze static checks * Remove duplicate entry * Use simpler approach for alias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #42453
Related: #42370
This migrates the Get DAG Details API from
api_connexiontoapi_fastapi.