Skip to content

feat(providers/common/sql): add warning to connection setter #42736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Oct 4, 2024
Merged

feat(providers/common/sql): add warning to connection setter #42736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions airflow/providers/common/sql/hooks/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,15 @@ def connection(self) -> Connection:

@connection.setter
def connection(self, value: Any) -> None:
# This setter is for backward compatibility and should not be used.
# Since the introduction of connection property, the providers listed below
# breaks due to assigning value to self.connection
#
# apache-airflow-providers-mysql<5.7.1
# apache-airflow-providers-elasticsearch<5.5.1
# apache-airflow-providers-postgres<5.13.0
pass
if value != self.connection:
self.log.warning(
"This setter is for backward compatibility and should not be used.\n"
"Since the introduction of connection property, the providers listed below "
"breaks due to assigning value to self.connection in their __init__ method.\n"
"* apache-airflow-providers-mysql<5.7.1\n"
"* apache-airflow-providers-elasticsearch<5.5.1\n"
"* apache-airflow-providers-postgres<5.13.0"
)

@property
def connection_extra(self) -> dict:
Expand Down