Skip to content

Removed PR #41531 and added Xcom and Host DNS mapping support to Swarm Operator - #43014

Closed
spoutin wants to merge 0 commit into
apache:mainfrom
spoutin:main
Closed

spoutin wants to merge 0 commit into
apache:mainfrom
spoutin:main

Conversation

@spoutin

@spoutin spoutin commented Oct 14, 2024

Copy link
Copy Markdown
  • removed PR Add retrieve output docker swarm operator #41531 since it doesn't work on a mutli node environment since inspect_container from the docker sdk will not work if the docker container did run on the node which call the api. This results in a container not found error preventing the Operator from running. The code was since been removed since there is no way to guarantee the placement of the docker container.

  • adding Xcom support for docker logs. If do_xcom_push is true (default) the last line of the docker logs will be push to the xcom results. If xcom_all is set to true, all results will be push to xcom.

  • adding support for host dns mapping


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk

potiuk commented Oct 15, 2024

Copy link
Copy Markdown
Member

Could you please split this PR - revertion of the original PR should be done with git revert and then the two changes should also be separated out - each with unit tests.

@spoutin

spoutin commented Oct 16, 2024

Copy link
Copy Markdown
Author

@potiuk I'm not sure I can do a git revert since in the latest commits it looks like the provides directory was moved. There is no commit history on the docker_swarm.py and docker.py files.

@potiuk

potiuk commented Oct 16, 2024

Copy link
Copy Markdown
Member

@potiuk I'm not sure I can do a git revert since in the latest commits it looks like the provides directory was moved. There is no commit history on the docker_swarm.py and docker.py files.

I see. - still splitting it would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants