Skip to content

Run only ui tests for PR with new UI only changes. #43503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Oct 30, 2024
Merged

Run only ui tests for PR with new UI only changes. #43503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ef7910
Run only ui tests for PR with new UI only changes.
tirkarthi Oct 30, 2024
902467d
Revert test change to UI folder.
tirkarthi Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dev/breeze/src/airflow_breeze/utils/selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,12 +801,17 @@ def _get_test_types_to_run(self, split_to_individual_providers: bool = False) ->
test_always_files = self._matching_files(
FileGroupForCi.ALWAYS_TESTS_FILES, CI_FILE_GROUP_MATCHES, CI_FILE_GROUP_EXCLUDES
)
test_ui_files = self._matching_files(
FileGroupForCi.UI_FILES, CI_FILE_GROUP_MATCHES, CI_FILE_GROUP_EXCLUDES
)

remaining_files = (
set(all_source_files)
- set(matched_files)
- set(kubernetes_files)
- set(system_test_files)
- set(test_always_files)
- set(test_ui_files)
)
get_console().print(f"[warning]Remaining non test/always files: {len(remaining_files)}[/]")
count_remaining_files = len(remaining_files)
Expand Down
27 changes: 27 additions & 0 deletions dev/breeze/tests/test_selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,33 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str):
id="All tests should be run when tests_common/ change",
)
),
(
pytest.param(
("airflow/ui/src/index.tsx",),
{
"affected-providers-list-as-string": None,
"all-python-versions": "['3.9']",
"all-python-versions-list-as-string": "3.9",
"python-versions": "['3.9']",
"python-versions-list-as-string": "3.9",
"ci-image-build": "true",
"prod-image-build": "false",
"needs-helm-tests": "false",
"run-tests": "true",
"run-amazon-tests": "false",
"docs-build": "false",
"full-tests-needed": "false",
"skip-pre-commits": "check-provider-yaml-valid,flynt,identity,lint-helm-chart,mypy-airflow,mypy-dev,mypy-docs,mypy-providers,mypy-task-sdk,ts-compile-format-lint-www",
"upgrade-to-newer-dependencies": "false",
"parallel-test-types-list-as-string": "Always",
"providers-test-types-list-as-string": "",
"needs-mypy": "false",
"mypy-checks": "[]",
"run-ui-tests": "true",
},
id="Run only ui tests for PR with new UI only changes.",
)
),
],
)
def test_expected_output_pull_request_main(
Expand Down