Repository navigation
Conversation
hhhonzik
requested review from
hussein-awala and
jedcunningham
as code owners
November 12, 2024 16:04
boring-cyborg
Bot
added
area:providers
provider:cncf-kubernetes
hhhonzik
commented
Nov 12, 2024
eladkal
force-pushed
the
update-cnfc-kubernetes
branch
from
November 20, 2024 12:36
13b4572 to
06ce1a4
Compare
Contributor
|
can we have unit test to cover this change? |
Contributor
Author
|
I've seen a lot of issues with JobOperator, possibly thanks to this change - duplicated pod / job generators etc. With the update by @eladkal PodOperator seems to be working for us. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #36090
KuberentesJobOperatordidn't cancel jobs when they were cancelled via the UI.on_kill; fixed with workaround described here: Deferrable operator tasks do not callon_killmethod when fail or restarted #36090 (comment)