Skip to content

Refactor the Dag trigger form - #45220

Merged
jscheffl merged 10 commits into
apache:mainfrom
shubhamraj-git:reset_trigger_form
Dec 26, 2024
Merged

jscheffl merged 10 commits into
apache:mainfrom
shubhamraj-git:reset_trigger_form

Conversation

@shubhamraj-git

@shubhamraj-git shubhamraj-git commented Dec 26, 2024 •

Copy link
Copy Markdown
Contributor

Note:

This PR refactors the TriggerDAGForm component for some bugs and code refactors.

  1. Reset was not removing the error until the values are filled again.
  2. We have used field now instead of using the text.
  3. Used the inbuilt field error.
  4. Set the date validation check alert under ErrorAlert component.
  5. Close the form on once the query has been invalidated.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 26, 2024
Comment thread airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx
Comment thread airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side.

@jscheffl
jscheffl merged commit d4e0995 into apache:main Dec 26, 2024
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
* reset form

* use field

* use field error

* place error alert at down

* set width

* error alert for date

* show toaster after invalidating

* readonly props

* fetch conf
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* reset form

* use field

* use field error

* place error alert at down

* set width

* error alert for date

* show toaster after invalidating

* readonly props

* fetch conf
@shubhamraj-git
shubhamraj-git deleted the reset_trigger_form branch September 7, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants