Repository navigation
Import the right BaseOperator in baseoperatorlinks - #46895
Merged
Merged
Conversation
ashb
approved these changes
Feb 19, 2025
ashb
left a comment
Member
There was a problem hiding this comment.
I guess if this fixes it that's fine for now, but I don't think this is the "best" long term fix
Contributor
Author
|
Definitely not. But we should start making this change once we start moving providers to use task sdk imports. That way providers will not have a airflow.models import |
uranusjr
approved these changes
Feb 19, 2025
Member
|
This isn't running mypy-providers so I'm merging this now anyway |
ntr
pushed a commit
to ntr/airflow
that referenced
this pull request
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this issue on my PR:
Caused due to recent change: #46415
Changing back to the correct BaseOperator from models. We will make the move when we start moving providers to use task sdk cc @ashb
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.