Skip to content

Remove unused methods from auth managers - #47316

Merged
vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:vincbeck/clean_am
Mar 4, 2025
Merged

vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:vincbeck/clean_am

Conversation

@vincbeck

@vincbeck vincbeck commented Mar 3, 2025 •

Copy link
Copy Markdown
Contributor

Remove methods specific to Airflow 2 from auth manager interface and auth manager implementations. Now that Airflow 2 UI is gone, we can get rid of following methods in auth managers:

  • filter_permitted_menu_items
  • get_user_name
  • get_user_display_name
  • get_user
  • get_user_id
  • is_logged_in
  • get_url_logout
  • get_api_endpoints
  • register_views

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Comment thread airflow/auth/managers/base_auth_manager.py
@vincbeck
vincbeck force-pushed the vincbeck/clean_am branch from f42524d to ba1d49e Compare March 3, 2025 21:16
@vincbeck
vincbeck force-pushed the vincbeck/clean_am branch from ba1d49e to a02d2df Compare March 3, 2025 21:45
@vincbeck
vincbeck requested a review from ashb as a code owner March 3, 2025 21:45
@vincbeck
vincbeck force-pushed the vincbeck/clean_am branch 2 times, most recently from 369d794 to ea01577 Compare March 3, 2025 23:41
@vincbeck
vincbeck force-pushed the vincbeck/clean_am branch from ea01577 to 9d7bc5c Compare March 4, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants