Skip to content

AIP-38 Fix safari login loop for non ssl #47859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Mar 17, 2025
Merged

AIP-38 Fix safari login loop for non ssl #47859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion providers/fab/src/airflow/providers/fab/www/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ def index(self):
if g.user is not None and g.user.is_authenticated:
token = get_auth_manager().generate_jwt(g.user)
response = make_response(redirect(f"{conf.get('api', 'base_url')}", code=302))
response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=True)

secure = bool(conf.get("api", "ssl_cert"))
response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=secure)

Check warning

Code scanning / CodeQL

Failure to use secure cookies

Cookie is added without the HttpOnly attribute properly set.
Comment thread
pierrejeambrun marked this conversation as resolved.

return response
else:
Expand Down