Repository navigation
Fix: BigQuery connection UI defaults 'Use Legacy SQL' to true on edit - #49038
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:google
kandharvishnu
changed the title
2 tasks done
potiuk
approved these changes
Apr 10, 2025
Member
|
Sounds good I guess it's time to change it @VladaZakharova ? |
Contributor
|
yes, thank you, looks good :) |
…nu/airflow into Airflow-lazy_gettext
rawwar
approved these changes
Apr 11, 2025
Contributor
|
Pulled changes from main as the constraints issue is fixed on Main |
14 of 56 tasks
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the "Use Legacy SQL" checkbox in the Google BigQuery connection UI is automatically selected upon editing the connection—even when it was explicitly set to
Falseearlier.Impact
This unintended toggle leads to query execution failures when the DAGs are expecting standard SQL. Example error:
Fix
The PR ensures the "Use Legacy SQL" checkbox properly reflects the actual saved value, preventing silent overrides.