Repository navigation
Decrease default value of waiter_max_attempts in MwaaTriggerDagRunOperator - #49136
Conversation
o-nikolas
left a comment
There was a problem hiding this comment.
12 hours is the max runtime for an MWAA task (as of today), so I can see where that number came from. Leaving it up to the user to decide if they want anything smaller seems reasonable to me, and to not be opinionated on our end what is a good time for them.
However, if everyone else prefers this shorter time, I'm happy to commit to that :)
That's where the 12 hours was coming from :) Knowing this it makes sense, I do not think it is worth to update it back now it is merged though. |
|
I just realized that the sensor will still wait for 12 hours: Also, the docstrings contain default values so it looks like another PR will be needed. I can do it if you'd like :) |
Please do :) In that case, I'd follow Niko instructions and basically revert what I did but update the system test to only wait for, say, 15 mins? |
Having a timeout of 12 hours is a bit too much.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.