Repository navigation
Another place where we double clean the /mnt drive - #50565
Merged
Merged
Conversation
potiuk
requested review from
Copilot and
jedcunningham
and removed request for
ashb and
gopidesupavan
May 13, 2025 22:02
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to optimize the CI workflow by removing a redundant cleanup step that was causing double cleaning of the /mnt drive.
- Removed the "Prepare and cleanup runner" step from the workflow.
- Streamlined the CI process to avoid unnecessary duplicate cleanup operations.
Comments suppressed due to low confidence (1)
.github/workflows/ci-image-checks.yml:330
- [nitpick] Removing the cleanup step is a good move to avoid double cleaning; please ensure that any necessary cleanup is adequately handled elsewhere to prevent resource buildup.
- - name: "Prepare and cleanup runner"
jscheffl
approved these changes
May 14, 2025
kaxil
pushed a commit
that referenced
this pull request
May 14, 2025
(cherry picked from commit 918a207)
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
(cherry picked from commit 918a207)
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.