Skip to content

Fixing fab assets generation - #50664

Merged
vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:vincbeck/fab_asset_name
May 15, 2025
Merged

vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:vincbeck/fab_asset_name

Conversation

@vincbeck

Copy link
Copy Markdown
Contributor

Regenerating FAB assets to fix main. It happened again 2 days ago, I am attempting to fix that by updating optimization in webpack.config.js.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@amoghrajesh amoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see how it goes. Count my approval

@potiuk

potiuk commented May 15, 2025

Copy link
Copy Markdown
Member

Yeah. I wonder why it happens - maybe it's a date thing ?

@vincbeck

Copy link
Copy Markdown
Contributor Author

Yeah. I wonder why it happens - maybe it's a date thing ?

Yeah I dont really know :/

@vincbeck
vincbeck merged commit fe1b11d into apache:main May 15, 2025
@vincbeck
vincbeck deleted the vincbeck/fab_asset_name branch May 15, 2025 17:41
@amoghrajesh

Copy link
Copy Markdown
Contributor

@vincbeck we might need this on v3-0-test branch too. Saw some checks failing

@vincbeck

Copy link
Copy Markdown
Contributor Author

I guess applying the label after the merge is too late? We have to do it manually?

@amoghrajesh

Copy link
Copy Markdown
Contributor

Yeah. You can use the cherry picker cli

@vincbeck

Copy link
Copy Markdown
Contributor Author

You have any doc? :) I never did it :)

@potiuk

potiuk commented May 17, 2025

Copy link
Copy Markdown
Member

@potiuk

potiuk commented May 17, 2025

Copy link
Copy Markdown
Member

You can also use GitHub workflow :)

potiuk pushed a commit to potiuk/airflow that referenced this pull request May 17, 2025
(cherry picked from commit fe1b11d)

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
potiuk added a commit that referenced this pull request May 17, 2025
(cherry picked from commit fe1b11d)

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
@potiuk

potiuk commented May 17, 2025

Copy link
Copy Markdown
Member

The magic command in this case cherry_picker fe1b11dcd8b78238c5cad06758a43794787c9cdb v3-0-test

Cherry-picked and merged #50723

@potiuk potiuk added this to the Airflow 3.0.2 milestone May 17, 2025
@vincbeck

Copy link
Copy Markdown
Contributor Author

Thanks!

kaxil pushed a commit that referenced this pull request Jun 3, 2025
(cherry picked from commit fe1b11d)

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants