Skip to content

[v3-0-test] Update config endpoint to use the get interface (#50902) #50910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
May 22, 2025
Merged

[v3-0-test] Update config endpoint to use the get interface (#50902) #50910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b57fdd4
Update config endpoint to use the get interface (#50902)
pierrejeambrun May 21, 2025
6f13ad5
Fix CI
pierrejeambrun May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions airflow-core/src/airflow/api_fastapi/core_api/routes/ui/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@
)
def get_configs() -> ConfigResponse:
"""Get configs for UI."""
conf_dict = conf.as_dict()

config = {key: conf_dict["webserver"].get(key) for key in WEBSERVER_CONFIG_KEYS}
config = {key: conf.get("webserver", key) for key in WEBSERVER_CONFIG_KEYS}

additional_config: dict[str, Any] = {
"instance_name": conf.get("webserver", "instance_name", fallback="Airflow"),
Expand Down
35 changes: 17 additions & 18 deletions airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
# under the License.
from __future__ import annotations

from unittest.mock import patch

import pytest

from tests_common.test_utils.config import conf_vars

pytestmark = pytest.mark.db_test

mock_config_response = {
Expand All @@ -44,23 +44,22 @@ def mock_config_data():
"""
Mock configuration settings used in the endpoint.
"""
with patch("airflow.configuration.conf.as_dict") as mock_conf:
mock_conf.return_value = {
"webserver": {
"page_size": "100",
"auto_refresh_interval": "3",
"hide_paused_dags_by_default": "false",
"instance_name": "Airflow",
"instance_name_has_markup": "false",
"enable_swagger_ui": "true",
"require_confirmation_dag_change": "false",
"default_wrap": "false",
"warn_deployment_exposure": "false",
"audit_view_excluded_events": "",
"audit_view_included_events": "",
}
with conf_vars(
{
("webserver", "page_size"): "100",
("webserver", "auto_refresh_interval"): "3",
("webserver", "hide_paused_dags_by_default"): "false",
("webserver", "instance_name"): "Airflow",
("webserver", "instance_name_has_markup"): "false",
("webserver", "enable_swagger_ui"): "true",
("webserver", "require_confirmation_dag_change"): "false",
("webserver", "default_wrap"): "false",
("webserver", "audit_view_excluded_events"): "",
("webserver", "audit_view_included_events"): "",
("webserver", "warn_deployment_exposure"): "false",
}
yield mock_conf
):
yield


class TestGetConfig:
Expand Down