Repository navigation
Conversation
…er ti.logical_date is None as it's valid
Lee-W
force-pushed
the
fix-asset-inlet-outlet-validation-return-ti-not-found
branch
from
June 6, 2025 04:16
fd7ffb3 to
91cf15d
Compare
amoghrajesh
approved these changes
Jun 6, 2025
phanikumv
reviewed
Jun 6, 2025
phanikumv
left a comment
Contributor
There was a problem hiding this comment.
Can you please correct the typos in the description:
ti.logicate_date
lociate_date
Member
Author
fixed |
Contributor
what about |
Member
Author
also fixed the one in what seciton |
phanikumv
approved these changes
Jun 6, 2025
Member
Author
|
I'll go ahead mering it and backporting it to |
Contributor
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
validate_inlets_and_outletscurrently checks whetherti.logical_dateis None, which causes all asset triggered dags to fail as they have theirlogical_dateset as None and it's expectedWhat
Remove the
ti.logical_datecheck invalidate_inlets_and_outlets^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.