Skip to content

Remove logical_date check when validate inlets and outlets - #51464

Merged
Lee-W merged 1 commit into
apache:mainfrom
astronomer:fix-asset-inlet-outlet-validation-return-ti-not-found
Jun 6, 2025
Merged

Lee-W merged 1 commit into
apache:mainfrom
astronomer:fix-asset-inlet-outlet-validation-return-ti-not-found

Conversation

@Lee-W

@Lee-W Lee-W commented Jun 6, 2025 •

Copy link
Copy Markdown
Member

Why

validate_inlets_and_outlets currently checks whether ti.logical_date is None, which causes all asset triggered dags to fail as they have their logical_date set as None and it's expected

What

Remove the ti.logical_date check in validate_inlets_and_outlets


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Lee-W
Lee-W requested review from amoghrajesh, ashb and kaxil as code owners June 6, 2025 03:46
@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label Jun 6, 2025
@Lee-W Lee-W changed the title fix(task_instance): validate_inlets_and_outlets shouldn't check whether ti.logical_date is None as it's valid Ignore logical_date checking when validate inlets and outlets Jun 6, 2025
@Lee-W Lee-W changed the title Ignore logical_date checking when validate inlets and outlets Do not check logical_date when validate inlets and outlets Jun 6, 2025
@Lee-W Lee-W changed the title Do not check logical_date when validate inlets and outlets Remove logical_date check when validate inlets and outlets Jun 6, 2025
@Lee-W
Lee-W force-pushed the fix-asset-inlet-outlet-validation-return-ti-not-found branch from fd7ffb3 to 91cf15d Compare June 6, 2025 04:16

@amoghrajesh amoghrajesh left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. LGTM +1

It seems it was an overlook while reviewing the initial PR

@phanikumv phanikumv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please correct the typos in the description:

ti.logicate_date
lociate_date

@Lee-W

Lee-W commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

lociate

fixed

@phanikumv

Copy link
Copy Markdown
Contributor

lociate

fixed

what about ti.logicate

@Lee-W

Lee-W commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

lociate

fixed

what about ti.logicate

also fixed the one in what seciton

@Lee-W

Lee-W commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

I'll go ahead mering it and backporting it to v3-0-test

@Lee-W
Lee-W merged commit 8865dbd into apache:main Jun 6, 2025
@Lee-W
Lee-W deleted the fix-asset-inlet-outlet-validation-return-ti-not-found branch June 6, 2025 07:08
github-actions Bot pushed a commit that referenced this pull request Jun 6, 2025
…ets (#51464)

(cherry picked from commit 8865dbd)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@github-actions

github-actions Bot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-0-test

Status Branch Result
✅ v3-0-test PR Link

kaxil pushed a commit that referenced this pull request Jun 6, 2025
…ets (#51464) (#51469)

(cherry picked from commit 8865dbd)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
kaxil pushed a commit that referenced this pull request Jun 6, 2025
…ets (#51464) (#51469)

(cherry picked from commit 8865dbd)

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
sanederchik pushed a commit to sanederchik/airflow that referenced this pull request Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants