Repository navigation
bug fix - evicted pod not inclued in creating pod - #53059
Merged
romsharon98 merged 3 commits intoJul 18, 2025
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:cncf-kubernetes
kyungjunleeme
force-pushed
the
fix/kpo-ignore-evicted-pod
branch
from
July 9, 2025 08:11
838950b to
d1c8fcf
Compare
kyungjunleeme
marked this pull request as ready for review
July 9, 2025 08:11
kyungjunleeme
requested review from
hussein-awala and
jedcunningham
as code owners
July 9, 2025 08:11
Contributor
Author
|
I will check another part. (in case of similar case) |
kyungjunleeme
force-pushed
the
fix/kpo-ignore-evicted-pod
branch
from
July 10, 2025 15:01
d1c8fcf to
5655a04
Compare
kyungjunleeme
force-pushed
the
fix/kpo-ignore-evicted-pod
branch
from
July 11, 2025 08:47
5655a04 to
f06a626
Compare
1 of 2 tasks
potiuk
approved these changes
Jul 15, 2025
potiuk
left a comment
potiuk
left a comment
Member
There was a problem hiding this comment.
Looks good - but I would like others who have more k8s experience to take a look
romsharon98
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #53015
yet, I'm not assined, If is problem, I will closed pr. in advance Thanks
Context
Previously, if a pod was in the Running phase, it was always reused when reattach_on_restart=True, regardless of its reason. However, in certain cases like eviction (status.reason == "Evicted"), the pod is not reusable in practice, especially when it cannot produce or expose XComs.
What was changed
get_or_create_pod()to exclude pods with reason="Evicted" from being reused, even if their phase is Running.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.