Skip to content

Cleanup type ignores in apache/hive provider - #53302

Merged
gopidesupavan merged 10 commits into
apache:mainfrom
mingdaoy:53241-cleanup-apache-hive
Jul 15, 2025
Merged

gopidesupavan merged 10 commits into
apache:mainfrom
mingdaoy:53241-cleanup-apache-hive

Conversation

@mingdaoy

Copy link
Copy Markdown
Contributor

related #53241
image


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk

potiuk commented Jul 13, 2025

Copy link
Copy Markdown
Member

Some errors :)

Comment thread providers/apache/hive/src/airflow/providers/apache/hive/hooks/hive.py Outdated
…hive.py

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Comment thread providers/apache/hive/src/airflow/providers/apache/hive/hooks/hive.py Outdated
@gopidesupavan

Copy link
Copy Markdown
Member

@mingdaoy can you please fix failing checks?

@potiuk

potiuk commented Jul 14, 2025

Copy link
Copy Markdown
Member

Yeah... that's the last one !

@mingdaoy

mingdaoy commented Jul 14, 2025 •

Copy link
Copy Markdown
Contributor Author

Thanks for waiting! @gopidesupavan

I tested it with

python -m mypy providers/apache/hive/src/airflow/providers/apache/hive/hooks/hive.py
image




Green light on CI MyPy checks (mypy-providers)

image

https://github.com/apache/airflow/actions/runs/16274625390/job/45950956404?pr=53302#step:6:3969

@gopidesupavan

Copy link
Copy Markdown
Member

Thanks for waiting! @gopidesupavan

I tested it with

python -m mypy providers/apache/hive/src/airflow/providers/apache/hive/hooks/hive.py
image Green light on CI MyPy checks (mypy-providers) image https://github.com/apache/airflow/actions/runs/16274625390/job/45950956404?pr=53302#step:6:3969

no rush at all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants