Skip to content

Move out some exceptions to TaskSDK - #54505

Merged
ephraimbuddy merged 36 commits into
apache:mainfrom
astronomer:exception-separation
Nov 26, 2025
Merged

Move out some exceptions to TaskSDK#54505
ephraimbuddy merged 36 commits into
apache:mainfrom
astronomer:exception-separation

Conversation

@ephraimbuddy

@ephraimbuddy ephraimbuddy commented Aug 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

As part of the ongoing server/client separation,
this commit moves out some exceptions to the Task sdk.

ashb
ashb reviewed Aug 14, 2025
View reviewed changes
Comment thread task-sdk/tests/task_sdk/execution_time/test_task_runner.py Outdated
@ephraimbuddy
ephraimbuddy force-pushed the exception-separation branch 3 times, most recently from f4a380e to 7a4587c Compare August 15, 2025 07:48
@ephraimbuddy
ephraimbuddy marked this pull request as ready for review August 15, 2025 07:51
kaxil
kaxil reviewed Aug 19, 2025
View reviewed changes
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py Outdated
kaxil
kaxil reviewed Aug 19, 2025
View reviewed changes
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py Outdated
kaxil
kaxil reviewed Aug 19, 2025
View reviewed changes
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py Outdated
kaxil
kaxil reviewed Aug 19, 2025
View reviewed changes
Comment thread airflow-core/src/airflow/api_fastapi/execution_api/routes/connections.py Outdated
kaxil
kaxil reviewed Aug 19, 2025
View reviewed changes
Comment thread airflow-core/src/airflow/models/connection.py Outdated
@ephraimbuddy ephraimbuddy mentioned this pull request Aug 20, 2025
Closed
1 task done
@ephraimbuddy
ephraimbuddy force-pushed the exception-separation branch 7 times, most recently from 90180cf to 59d7f90 Compare August 24, 2025 18:17
@ephraimbuddy
Retain AirflowNotFoundException
6105a09
@ephraimbuddy
AirflowException now inherits from RuntimeError, update provider changes
2cca599
@ephraimbuddy
fixup! AirflowException now inherits from RuntimeError, update provid…
43e8a89 
…er changes
@ephraimbuddy
Now that AirflowException inherits from Runtime, remove change of Air…
fbccc23 
…flowException to RuntimeError
@ephraimbuddy
Fix imports and exception use in providers
6461aff
@ephraimbuddy
Explicitly cover for shared packages in exception
5110ec3
@ephraimbuddy
Fix ruff broadexception
a5ce61e
@ephraimbuddy
fix mypy issue
27cfbb5
@ephraimbuddy
remove unintended file addition
27d9a6c
@ephraimbuddy
Remove left over cleanup
be1feba
@ephraimbuddy
Return exception to AirflowException
dfa8a6e
@ephraimbuddy
Use import_string
79bd1eb
@ephraimbuddy
Fix static checks
cdd460f
@ephraimbuddy
Revert subclassing AirflowException from Runtime
87aff12
@ephraimbuddy
Fix providers importing deprecated exceptions to use compat SDK
de216f9
@ephraimbuddy
fixup! Fix providers importing deprecated exceptions to use compat SDK
964bbca
@ephraimbuddy
Use ModuleNotFoundError in exception if airflow.sdk is not installed(…
afcf1fa 
…usually caused by _AIRFLOW__AS_LIBRARY
@ephraimbuddy
Fix Airflow 2 compat
0611b29
@ephraimbuddy
Use ValueError instead of RuntimeError were appropriate
cec855b
@ephraimbuddy
Update compat to have only the imports used in provider
efa0075
@ephraimbuddy
Update example dag import and fix mypy error
b0b1b14
@ephraimbuddy
fix conflict
7d7cd20
@ephraimbuddy
Add news fragment item
9a5bf3d
@ephraimbuddy
fixup! Add news fragment item
8b77862
@amoghrajesh

amoghrajesh commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

🥳

@jscheffl jscheffl mentioned this pull request Nov 27, 2025
Closed
16 of 62 tasks
@potiuk

potiuk commented Nov 28, 2025

Copy link
Copy Markdown
Member

nice!

This was referenced Nov 28, 2025
Merged
Closed
@amoghrajesh amoghrajesh mentioned this pull request Jan 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjr uranusjr uranusjr left review comments
@amoghrajesh amoghrajesh amoghrajesh approved these changes
@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun
@rawwar rawwar Awaiting requested review from rawwar
@jason810496 jason810496 Awaiting requested review from jason810496
@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93
@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner
@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner
@XD-DENG XD-DENG Awaiting requested review from XD-DENG
@dstandish dstandish Awaiting requested review from dstandish
@potiuk potiuk Awaiting requested review from potiuk
@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner
@hussein-awala hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner
@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner
@eladkal eladkal Awaiting requested review from eladkal
@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner
@kaxil kaxil Awaiting requested review from kaxil
@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan
@ashb ashb Awaiting requested review from ashb ashb is a code owner

Assignees

@ephraimbuddy ephraimbuddy

Labels

area:task-sdk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ephraimbuddy @kaxil @ashb @amoghrajesh @potiuk @uranusjr @phanikumv