Skip to content

Add hyperlinks to dag_id column in Dag Runs and Task Instances pages - #55648

Merged
bbovenzi merged 1 commit into
apache:mainfrom
dheerajturaga:feature/hyperlink-dagid-ui
Sep 17, 2025
Merged

Add hyperlinks to dag_id column in Dag Runs and Task Instances pages#55648
bbovenzi merged 1 commit into
apache:mainfrom
dheerajturaga:feature/hyperlink-dagid-ui

Conversation

@dheerajturaga

@dheerajturaga dheerajturaga commented Sep 14, 2025

Copy link
Copy Markdown
Member
  • Make dag_display_name clickable in DagRuns.tsx to navigate to dag page
  • Make dag_display_name clickable in TaskInstances.tsx to navigate to dag page
image

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 14, 2025
@eladkal eladkal modified the milestones: Airflow 3.1.1, Airflow 3.1.0 Sep 15, 2025
guan404ming
guan404ming approved these changes Sep 15, 2025
View reviewed changes

@guan404ming guan404ming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bbovenzi

bbovenzi commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

Originally we only linked to the Dag Run, Dag or Task Instance in question instead of showing multiple links at once and possibly confusing a user.

So let's only make the task instance or dag run link text bold and the rest have a normal font weight? All of them being bold is definitely distracting

@dheerajturaga
dheerajturaga force-pushed the feature/hyperlink-dagid-ui branch from 35dbf4f to bf8f540 Compare September 16, 2025 13:59
@dheerajturaga

dheerajturaga commented Sep 16, 2025

Copy link
Copy Markdown
Member Author

Originally we only linked to the Dag Run, Dag or Task Instance in question instead of showing multiple links at once and possibly confusing a user.

So let's only make the task instance or dag run link text bold and the rest have a normal font weight? All of them being bold is definitely distracting

Agreed! I removed the bold from the font

image

bbovenzi
bbovenzi reviewed Sep 16, 2025
View reviewed changes

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. If we're going to do this. Then we probably also want the dag run in the Task Instances table to also have a link, no?

@dheerajturaga

dheerajturaga commented Sep 16, 2025

Copy link
Copy Markdown
Member Author

Nice. If we're going to do this. Then we probably also want the dag run in the Task Instances table to also have a link, no?

Yes, and thats already a part of this PR aswell

image

@bbovenzi

bbovenzi commented Sep 16, 2025

Copy link
Copy Markdown
Contributor

Nice. If we're going to do this. Then we probably also want the dag run in the Task Instances table to also have a link, no?

Yes, and thats already a part of this PR aswell

image

No, I mean that Dag Run column there should also have a link?

@dheerajturaga

dheerajturaga commented Sep 16, 2025

Copy link
Copy Markdown
Member Author

Nice. If we're going to do this. Then we probably also want the dag run in the Task Instances table to also have a link, no?

Yes, and thats already a part of this PR aswell
image

No, I mean that Dag Run column there should also have a link?

Hmm interesting, The Column is Dag Run and not Dag Run ID . The column is a date. Should I change this to point to Dag Run ID?

I would prefer to tackle that in a separate PR if thats the case

bbovenzi
bbovenzi approved these changes Sep 16, 2025
View reviewed changes

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

@dheerajturaga
dheerajturaga force-pushed the feature/hyperlink-dagid-ui branch from bf8f540 to aeccd53 Compare September 16, 2025 14:34
@dheerajturaga

dheerajturaga commented Sep 16, 2025

Copy link
Copy Markdown
Member Author

@bbovenzi , I assume the CI fails are unrelated? It complains about breeze docs?

@bbovenzi

bbovenzi commented Sep 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@dheerajturaga Probably but let's rebase just to make sure

@dheerajturaga
Add hyperlinks to dag_id column in Dag Runs and Task Instances pages
eb8246b 
  - Make dag_display_name clickable in DagRuns.tsx to navigate to dag page
  - Make dag_display_name clickable in TaskInstances.tsx to navigate to dag page
@dheerajturaga
dheerajturaga force-pushed the feature/hyperlink-dagid-ui branch from aeccd53 to eb8246b Compare September 17, 2025 06:15
@bbovenzi
bbovenzi merged commit 30ccb2b into apache:main Sep 17, 2025
56 checks passed
kaxil pushed a commit that referenced this pull request Sep 18, 2025
@dheerajturaga @kaxil
Add hyperlinks to dag_id column in Dag Runs and Task Instances pages (#…
91790ea 
…55648)

- Make dag_display_name clickable in DagRuns.tsx to navigate to dag page
  - Make dag_display_name clickable in TaskInstances.tsx to navigate to dag page

(cherry picked from commit 30ccb2b)
@dheerajturaga dheerajturaga mentioned this pull request Sep 18, 2025
Closed
12 of 15 tasks
@potiuk potiuk mentioned this pull request Nov 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzi bbovenzi bbovenzi approved these changes
@guan404ming guan404ming guan404ming approved these changes
@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner
@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner
@jscheffl jscheffl Awaiting requested review from jscheffl
@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

Airflow 3.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dheerajturaga @bbovenzi @guan404ming @eladkal