Skip to content

fix(APDR): add asset events to partitioned DagRun - #61433

Merged
potiuk merged 8 commits into
apache:mainfrom
astronomer:add-asset-event-to-partitioned-dag-run
Feb 16, 2026
Merged

fix(APDR): add asset events to partitioned DagRun#61433
potiuk merged 8 commits into
apache:mainfrom
astronomer:add-asset-event-to-partitioned-dag-run

Conversation

@Lee-W

@Lee-W Lee-W commented Feb 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Why

consumed_asset_evnets was not appended for the partitioned DagRun

What

Ensure asset events are not missed for the partitioned DagRun

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Lee-W
Lee-W requested review from XD-DENG and ashb as code owners February 4, 2026 06:59
@Lee-W
Lee-W requested review from dstandish and removed request for XD-DENG and ashb February 4, 2026 06:59
@Lee-W Lee-W moved this to In Progress in AIP-76 Asset Partitioning Feb 4, 2026
@Lee-W
Lee-W force-pushed the add-asset-event-to-partitioned-dag-run branch 2 times, most recently from 43213fb to f346fff Compare February 6, 2026 09:10
@Lee-W Lee-W self-assigned this Feb 9, 2026
@Lee-W
Lee-W force-pushed the add-asset-event-to-partitioned-dag-run branch from f346fff to 57b22e1 Compare February 9, 2026 09:00
@uranusjr

uranusjr commented Feb 9, 2026

Copy link
Copy Markdown
Member

Hmm, how do non-partitioned events do this?

@Lee-W

Lee-W commented Feb 9, 2026

Copy link
Copy Markdown
Member Author

Hmm, how do non-partitioned events do this?

looks like they have a simliar implementation

airflow/airflow-core/src/airflow/jobs/scheduler_job_runner.py

Line 2090 in 5953b82

dag_run.consumed_asset_events.extend(asset_events)

@Lee-W
Lee-W force-pushed the add-asset-event-to-partitioned-dag-run branch from 57b22e1 to 526cdff Compare February 12, 2026 02:35
@Lee-W
Lee-W force-pushed the add-asset-event-to-partitioned-dag-run branch from 526cdff to ceba945 Compare February 13, 2026 10:20
guan404ming
guan404ming approved these changes Feb 15, 2026
View reviewed changes

@guan404ming guan404ming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@potiuk
potiuk merged commit f504ba7 into apache:main Feb 16, 2026
72 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in AIP-76 Asset Partitioning Feb 16, 2026
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
@Lee-W @choo121600
fix(APDR): add asset events to partitioned DagRun (apache#61433)
b2a113b 
* test: simplify test_partitioned_dag_run_with_customized_mapper

* test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fix(APDR): add asset events to partitioned DagRun

* fixup! fix(APDR): add asset events to partitioned DagRun

* fixup! test: simplify test_partitioned_dag_run_with_customized_mapper

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
@Lee-W @Subham-KRLX
fix(APDR): add asset events to partitioned DagRun (apache#61433)
2cce342 
* test: simplify test_partitioned_dag_run_with_customized_mapper

* test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fix(APDR): add asset events to partitioned DagRun

* fixup! fix(APDR): add asset events to partitioned DagRun

* fixup! test: simplify test_partitioned_dag_run_with_customized_mapper

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
@Lee-W @dominikhei
fix(APDR): add asset events to partitioned DagRun (apache#61433)
5bcd686 
* test: simplify test_partitioned_dag_run_with_customized_mapper

* test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fix(APDR): add asset events to partitioned DagRun

* fixup! fix(APDR): add asset events to partitioned DagRun

* fixup! test: simplify test_partitioned_dag_run_with_customized_mapper

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@Lee-W @Ankurdeewan
fix(APDR): add asset events to partitioned DagRun (apache#61433)
e38c18a 
* test: simplify test_partitioned_dag_run_with_customized_mapper

* test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fix(APDR): add asset events to partitioned DagRun

* fixup! fix(APDR): add asset events to partitioned DagRun

* fixup! test: simplify test_partitioned_dag_run_with_customized_mapper

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation
radhwene pushed a commit to radhwene/airflow that referenced this pull request Mar 21, 2026
@Lee-W root
fix(APDR): add asset events to partitioned DagRun (apache#61433)
708ce53 
* test: simplify test_partitioned_dag_run_with_customized_mapper

* test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fix(APDR): add asset events to partitioned DagRun

* fixup! fix(APDR): add asset events to partitioned DagRun

* fixup! test: simplify test_partitioned_dag_run_with_customized_mapper

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation

* fixup! test(scheduler_job): improve APDR test cases to include consumed_asset_event validation
@Mercury2699 Mercury2699 mentioned this pull request Jun 4, 2026
Closed
@bujjibabukatta bujjibabukatta mentioned this pull request Jun 5, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes
@guan404ming guan404ming guan404ming approved these changes
@dstandish dstandish Awaiting requested review from dstandish
@jason810496 jason810496 Awaiting requested review from jason810496

Assignees

@Lee-W Lee-W

Labels

area:scheduler

Projects

No open projects
AIP-76 Asset Partitioning
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lee-W @uranusjr @potiuk @guan404ming