Repository navigation
Fix Celery worker crash on macOS due to unpicklable local function - #62655
Merged
dheerajturaga merged 2 commits intoMar 2, 2026
Merged
dheerajturaga merged 2 commits into
dheerajturaga merged 2 commits into
Conversation
This comment was marked as spam.
This comment was marked as spam.
o-nikolas
reviewed
Mar 1, 2026
o-nikolas
left a comment
o-nikolas
left a comment
Contributor
There was a problem hiding this comment.
Code looks reasonable to me. Any way we can add a test to avoid future regression?
Move bundle_cleanup_main() from a local function inside _run_stale_bundle_cleanup() to module-level _bundle_cleanup_main(). On macOS, multiprocessing uses spawn instead of fork, and local functions cannot be pickled for spawning across processes. Closes: apache#62512 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
I made the exact same change a few days ago: #62528 . What a coincidence. |
dheerajturaga
approved these changes
Mar 2, 2026
dheerajturaga
left a comment
dheerajturaga
left a comment
Member
There was a problem hiding this comment.
Thanks! For catching this 😃
1 task
Member
|
Nice! |
27 of 55 tasks
dominikhei
pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bundle_cleanup_main()from a local function inside_run_stale_bundle_cleanup()to module-level_bundle_cleanup_main(check_interval)spawninstead offork, and local functions cannot be pickled for spawning across processesserve_logs(module-level function used withProcess(target=serve_logs))Co-contributors : @codingrealitylabs @girlcoder-gaming
Test plan
Closes: #62512
🤖 Generated with Claude Code