Skip to content

Fix missing deprecation for execution_api_server_url mapping - #63949

Merged
potiuk merged 2 commits into
apache:mainfrom
Jadu07:fix-missing-execution-api-server-url-deprecation
Apr 4, 2026
Merged

potiuk merged 2 commits into
apache:mainfrom
Jadu07:fix-missing-execution-api-server-url-deprecation

Conversation

@Jadu07

@Jadu07 Jadu07 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

When execution_api_server_url was moved from [workers] to [core], the transition lacked a backward-compatibility deprecation mapping in parser.py.

As a result, Airflow 3 SDK ignores user configurations still placed under [workers], falling back to an often unresolvable Default URL derived from api.base_url. This caused Task SDK pods to crash on startup with an httpcore.ConnectError and prevented the task's hostname from being properly reported, resulting in Invalid URL log fetch errors in the UI.

This commit adds execution_api_server_url to deprecated_options to restore proper fallback behavior.

closes: #63945


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Google DeepMind for verification of the changes made.

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@potiuk potiuk added the ready for maintainer review Set by triage when all criteria pass, or by the fork CI reconciler when fork CI is green. label Mar 20, 2026
@Jadu07

Jadu07 commented Mar 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Hello sir @eladkal @gopidesupavan , please review this PR?

@eladkal
eladkal requested review from Lee-W and jason810496 March 25, 2026 06:44
@Lee-W

Lee-W commented Mar 26, 2026

Copy link
Copy Markdown
Member

it was there since 3.0.0. I'm not sure why it relates to #63945

When execution_api_server_url was moved from [workers] to [core], the transition lacked a backward-compatibility deprecation mapping in parser.py.

As a result, Airflow 3 SDK ignores user configurations still placed under [workers], falling back to an often unresolvable Default URL derived from api.base_url. This caused Task SDK pods to crash on startup with an httpcore.ConnectError and prevented the task's hostname from being properly reported, resulting in Invalid URL log fetch errors in the UI.

This commit adds execution_api_server_url to deprecated_options to restore proper fallback behavior.
@Jadu07
Jadu07 force-pushed the fix-missing-execution-api-server-url-deprecation branch from 6076f15 to 28bb2f2 Compare March 26, 2026 10:50
@Jadu07

Jadu07 commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

it was there since 3.0.0. I'm not sure why it relates to #63945

Thank you for catching this! You are absolutely right that execution_api_server_url has been in [core] since 3.0.0.

However, because the deprecation mapping in parser.py was never added back then, any legacy configuration still pointing to [workers] is silently ignored, leading to the broken log symptoms reported in #63945.
I have amended the PR to use version 3.0 instead to accurately reflect this.

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was there since 3.0.0. I'm not sure why it relates to #63945

So do I, deprecating the [core/execution_api_server_url] doesn't seem to help resolve #63945.

@Jadu07

Jadu07 commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

it was there since 3.0.0. I'm not sure why it relates to #63945

So do I, deprecating the [core/execution_api_server_url] doesn't seem to help resolve #63945.

PR #46969 moved this from [workers] to [core] across multiple executors and the Helm chart, but missed this deprecation shim.

Without it, legacy [workers] configs are ignored, causing the ConnectError and the NULL hostname leading to the log fetch error in #63945.

@Jadu07
Jadu07 requested a review from jason810496 March 26, 2026 16:35
@Lee-W

Lee-W commented Mar 31, 2026

Copy link
Copy Markdown
Member

Could you help clarify why we should support this? Airflow 2 to 3 may be one of the limited opportunities we have to remove elements we don’t intend to keep.

@kaxil
kaxil requested a review from Copilot April 2, 2026 00:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@potiuk
potiuk merged commit 9fa72ac into apache:main Apr 4, 2026
64 checks passed
@vatsrahul1001 vatsrahul1001 added this to the Airflow 3.3.0 milestone Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for maintainer review Set by triage when all criteria pass, or by the fork CI reconciler when fork CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The problem of executing DAG's and getting logs after migration to 3.1.8

7 participants