Skip to content

Fix dag_display_name property bypass for DagStats query #64256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Mar 26, 2026
Merged

Fix dag_display_name property bypass for DagStats query #64256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions airflow-core/src/airflow/api_fastapi/common/db/dag_runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,18 @@
if TYPE_CHECKING:
from sqlalchemy.orm import Session

# Use the hybrid_property for dag_display_name so the CASE WHEN fallback to dag_id
# is applied when dag_display_name is NULL. Using __table__.c would return raw NULLs
# and crash DagStatsResponse validation (https://github.com/apache/airflow/issues/64247).
dagruns_select_with_state_count = (
select(
select( # type: ignore[call-overload]
DagRun.__table__.c.dag_id,
DagRun.__table__.c.state,
DagModel.__table__.c.dag_display_name,
DagModel.dag_display_name,
func.count(DagRun.__table__.c.state).label("count"),
)
.join(DagModel, DagRun.__table__.c.dag_id == DagModel.__table__.c.dag_id)
.group_by(DagRun.__table__.c.dag_id, DagRun.__table__.c.state, DagModel.__table__.c.dag_display_name)
.group_by(DagRun.__table__.c.dag_id, DagRun.__table__.c.state, DagModel.dag_display_name)
.order_by(DagRun.__table__.c.dag_id)
)

Expand Down
Loading