Repository navigation
Add workers.celery.annotations field - #64982
Conversation
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Pull request overview
Introduces a new Helm values field workers.celery.annotations for Celery worker Deployment/StatefulSet annotations and deprecates the legacy workers.annotations field, aligning worker configuration with the existing workers.celery.* structure.
Changes:
- Add
workers.celery.annotationstovalues.yamlandvalues.schema.json, and markworkers.annotationsas deprecated. - Add a Helm NOTES deprecation warning when
workers.annotationsis used. - Update Helm chart tests to validate annotation precedence/overrides across
workers.annotations,workers.celery.annotations, and worker sets.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| helm-tests/tests/helm_tests/airflow_core/test_worker.py | Updates annotation test coverage for new workers.celery.annotations path and precedence. |
| helm-tests/tests/helm_tests/airflow_core/test_worker_sets.py | Extends worker-set annotation overwrite tests to include workers.celery.annotations. |
| chart/values.yaml | Documents deprecation of workers.annotations and adds workers.celery.annotations. |
| chart/values.schema.json | Updates schema docs for deprecated field and adds schema entry for workers.celery.annotations. |
| chart/templates/NOTES.txt | Adds a deprecation warning for workers.annotations. |
| chart/newsfragments/64982.significant.rst | Adds release-note entry for the deprecation/rename. |
I was thinking about adding something like that in the future, as it would require implementing custom rendering logic (
Also, when I have a little more time (probably soon, as the whole move from |
beb7642 to
6d44246
Compare
* Add workers.celery.annotations * Add newsfragment (cherry picked from commit 3564d44) Co-authored-by: Przemysław Mirowski <17602603+Miretpl@users.noreply.github.com>
Backport successfully created: chart/v1-2x-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
related: #28880
This PR introduces a new
workers.celery.annotationssection and deprecates the oldworkers.annotationssection (as it was only applicable to Celery workers).Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.