Repository navigation
Conversation
b6ad7b5 to
ffa29cc
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
cf74efa to
38a269a
Compare
|
Hello @yuseok89 - thank you for your contributions to Apache Airflow! The Airflow community has introduced a limit of 5 open pull requests at a time for contributors without write access to the repository. You currently have 11 open pull requests, so - as a one-time step of introducing the limit - we closed the ones where maintainers have not engaged yet:
These pull requests stay open because maintainers are already engaged in them - they count towards your limit:
This is not a judgement of you or of your changes. We never told contributors before that opening many pull requests at once was a problem, so there is nothing to feel bad about - and nothing is lost: your branches, commits and the review history stay where they are. What we ask you to do is to make your first prioritization decision: choose which of the pull requests above matter most to you, and reopen them (up to 5 open at a time, including the ones still open) with the "Reopen pull request" button or While your pull requests are waiting for review, the most valuable thing you can do is help in other ways - reviewing other contributors' pull requests, helping with issues, and taking part in the discussions on the devlist and Slack. Why we introduced the limit, what it means for you and how to reopen or restore a pull request is explained in https://github.com/apache/airflow/blob/main/contributing-docs/32_open_pull_request_limit.rst. Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting |
closes: #28580
The
deferredbranch of the task lifecycle diagram asked "A triggerer task?", a question about task type, at exactly the point where the reader needs the event timeline. Waiting, the trigger firing, and the return toscheduledwere all collapsed behind that one branch, so the path out ofdeferredexisted but could not be followed.Diagram, deferred region
The branch now reads as a sequence of events.
deferred→ "Trigger fired?"deferred, the wait loopScheduler, an ordinary deferrable task resumes on a workerend_from_triggerpath"Task completes in the triggerer?" is not a rename for its own sake. It names the
BaseTaskEndEventoverload ofhandle_event_submit, whose user-facing subclasses areTaskSuccessEvent,TaskFailedEventandTaskSkippedEvent.A task that raises a defer signal now transitions straight to
deferredrather than to theTriggerernode. The worker writesDEFERREDand the trigger row in a single Execution API call, and a triggerer claims the trigger afterwards, so the old edge drew a synchronous hand-off that does not happen. The edge carries atrigger registeredlabel so the triggerer is still part of the story.Diagram, upstream failure check
Separate from the deferred work,
Required upstream task(s) failed?had its branches backwards.NOpointed atupstream_failedandYEScontinued towardscheduled. Its two sibling diamonds are oriented correctly, so this was an authoring slip rather than a house convention. It sits on the single path every task takes out of theSchedulerbox, and the deferred resume path this PR documents runs straight through it, so it is fixed here. Happy to split it into its own PR if reviewers prefer.Prose
deferring.rstcredited the scheduler with thedeferredtoscheduledwrite. The triggerer performs it, and the scheduler's owndeferredtoscheduledwrite is the trigger-timeout failure path. The same sentence promised a return to a worker unconditionally, which is not true forend_from_trigger. Both are corrected, and the paragraph that restated the bullets above it is reduced to the cross-reference it was carrying.Screenshots
Deferred region
Upstream failure check
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.